search

InnerSourceCommons / InnerSourceLearningPath

Holds the source material for the InnerSource Commons Learning Path
https://innersourcecommons.org/learningpath
Creative Commons Attribution Share Alike 4.0 International
74 stars 46 forks source link

Check in updated links to GitHub #538

Closed rrrutledge closed 1 year ago

rrrutledge commented 1 year ago

The publish script that runs on each checkin does a local update of translated links.

We should update the publish script to also commit the results of the script run back into the InnerSourceLearningPath repo.

tsadler1988 commented 1 year ago

This should be complete as of https://github.com/InnerSourceCommons/InnerSourceLearningPath/commit/a8b02d22c2439fdc08ff7fc84591ac3f2875608b. Tested via https://github.com/InnerSourceCommons/InnerSourceLearningPath/commit/63ddd5dae184200b1343255f6e524cc289c0a6c3 which resulted in https://github.com/InnerSourceCommons/InnerSourceLearningPath/commit/19f718ddf64e8c81c3261bbabed249798241b70e and it looks good!

Also fixed an issue where there is nothing to commit the build would fail, so made the commit and push conditional based on the presence of changes - see https://github.com/InnerSourceCommons/InnerSourceLearningPath/commit/4b03fb932e17ee380c755154822387ff2a353329.

rrrutledge commented 1 year ago

Thanks for this work, @tsadler1988❗ You manually put this deploy key in the repo settings?

tsadler1988 commented 1 year ago

You manually put this deploy key in the repo settings?

Yes that's right. There's no way of securely doing it in source control or with automation that I know of. I generated the key on my machine and deleted it once uploaded to GitHub.

rrrutledge commented 1 year ago

OK sounds great! Thanks, Tom!