search

InnerSourceCommons / InnerSourcePatterns

Proven approaches that can guide you through applying open source best practices within your organization
https://patterns.innersourcecommons.org
Creative Commons Attribution Share Alike 4.0 International
739 stars 181 forks source link

Switch to pull_request_target strategy #608

Closed zkoppert closed 11 months ago

zkoppert commented 11 months ago

fixes #581

This changes from running the gitbook workflow on the upstream repo to actually running it on the fork that a contributor has created with a changeset. The hope is that this will address the failing builds described in #581 . In order to test this change I believe we need to merge this through to the main branch and then open a pull request from a fork which would trigger this github action job.

cc/ @spier

spier commented 11 months ago

Thank you @zkoppert. This PR is merged.

Could you also create PR from your fork, to test if this works? I am worried that if I test this from my own fork, my elevated permissions on the upstream may create misleading results.

spier commented 11 months ago

I forgot that I can push changes to a PR submitted from a fork myself. And through that test the pull_request_target from a fork.

Just did that. However it looks like the workflow is still failing. See: https://github.com/InnerSourceCommons/InnerSourcePatterns/pull/579/checks