Open spier opened 7 months ago
The code tries to identify the issue, to which it should add a comment, by searching for issues with a given title: See: https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/.github/workflows/i18n-consistency-checker.yaml#L77
I suspect we have to modify this search to make sure that it always returns the correct issue.
Hunches
Also note that in in #586 we already want to make changes to this GHA. So these two issues might collide.
This is the search that is run
$ gh issue list -S "is:issue is:open :brazil: Brazilian Portuguese: Content Consistency Issue"
Showing 1 of 1 issue in InnerSourceCommons/InnerSourcePatterns that matches your search
#625 Quarterly Metrics: Board Report 2023-11 community metrics about 5 hours ago
This shows that an entirely wrong issue is returned.
I think we have to search like this:
$ gh issue list -S "is:issue is:open in:title ':brazil: Brazilian Portuguese: Content Consistency Issue'"
no issues match your search in InnerSourceCommons/InnerSourcePatterns
This looks correct, as no issue with that title exists.
Trying some searches that should return results now:
$ gh issue list -S "is:issue is:open in:title ':jp: Japanese: Content Consistency Issue'"
Showing 2 of 2 issues in InnerSourceCommons/InnerSourcePatterns that match your search
#627 :jp: Japanese: Content Consistency Issue Type - Translation about 12 hours ago
#584 :jp: Japanese: Content Consistency Issue Type - Translation about 1 month ago
$ gh issue list -S "is:issue is:open in:title ':cn: Chinese: Content Consistency Issue'"
Showing 2 of 2 issues in InnerSourceCommons/InnerSourcePatterns that match your search
#628 :cn: Chinese: Content Consistency Issue Type - Translation about 12 hours ago
#583 :cn: Chinese: Content Consistency Issue Type - Translation about 1 month ago
This looks correct. Going forward these searches should only return a single issue maximum, as at any given time only a single issue with the given title should be open.
The following files may have consistency issues with the English version. Please check and update the files.
This issue is created when any of the English patterns have changed (in folder ). It compares the git update history to let you know what updates are overdue. The issue should be closed when the update is complete.
The following files may have consistency issues with the English version. Please check and update the files.
This issue is created when any of the English patterns have changed (in folder ). It compares the git update history to let you know what updates are overdue. The issue should be closed when the update is complete.
The following files may have consistency issues with the English version. Please check and update the files.
This issue is created when any of the English patterns have changed (in folder ). It compares the git update history to let you know what updates are overdue. The issue should be closed when the update is complete.
The GHA workflow to check the translation content consistency should open a new issue for each language.
However for the language
pt-br
it did not do that. Instead it attached a comment to a completely different issue. See: https://github.com/InnerSourceCommons/InnerSourcePatterns/issues/625Likely a bug in
.github/workflows/i18n-consistency-checker.yaml
This is the workflow run that created the faulty comment: https://github.com/InnerSourceCommons/InnerSourcePatterns/actions/runs/7053945955/job/19201955600