InnerSourceCommons / InnerSourcePatterns

Proven approaches that can guide you through applying open source best practices within your organization
https://patterns.innersourcecommons.org
Creative Commons Attribution Share Alike 4.0 International
728 stars 177 forks source link

InnerSource pattern "Creating an InnerSource Strategy" #652

Closed misappi closed 2 months ago

misappi commented 5 months ago

I created a draft PR to start the discussion about that pattern. By intention, it only contains the most basic sections. Others will be added later based on feedback and the discussion in the community.

welcome[bot] commented 5 months ago

Thank You Banner

:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! :checkered_flag:

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

misappi commented 4 months ago

Thanks for sharing this @misappi ! I left some feedback inline, and will resolve the pieces that seem non-controversial (e.g. purely cosmetic/formatting changes).

One general question: Your pattern made me thing of the existing Document your Guiding Principles. I am not saying that both are after exactly the same but there might be some overlap.

Curious to hear your perspective on this.

Interesting. I did not know that pattern so far. You are right, there is an overlap to the strategy pattern since both are mentioning the purpose of introducting InnerSource to an organization.

Since this is the first pattern that I write, I am not sure how patterns are normally tailored at ISC. One possibility that I see is to adjust "Documenting your guilding principles" in a way that it focusses on the principles (and not the purpose - anyway the main part of the pattern is about principles). Purpose and the connection of InnerSource to the goals of an organization and its (business) strategy could be covered in "Creating an InnerSource strategy". Then, both patterns would nicely complement each other - at least IMO.

spier commented 4 months ago

Thanks for sharing this @misappi ! I left some feedback inline, and will resolve the pieces that seem non-controversial (e.g. purely cosmetic/formatting changes). One general question: Your pattern made me thing of the existing Document your Guiding Principles. I am not saying that both are after exactly the same but there might be some overlap. Curious to hear your perspective on this.

Interesting. I did not know that pattern so far. You are right, there is an overlap to the strategy pattern since both are mentioning the purpose of introducting InnerSource to an organization.

Since this is the first pattern that I write, I am not sure how patterns are normally tailored at ISC. One possibility that I see is to adjust "Documenting your guilding principles" in a way that it focusses on the principles (and not the purpose - anyway the main part of the pattern is about principles). Purpose and the connection of InnerSource to the goals of an organization and its (business) strategy could be covered in "Creating an InnerSource strategy". Then, both patterns would nicely complement each other - at least IMO.

Your idea sounds good too me. Let's keep your PR here as a separate pattern. Covering the connection of InnerSource to the goals of an organization and its (business) strategy would surely be great new content to have. The more specific we can make this pattern about that area the better :)

misappi commented 4 months ago

Thanks for sharing this @misappi ! I left some feedback inline, and will resolve the pieces that seem non-controversial (e.g. purely cosmetic/formatting changes). One general question: Your pattern made me thing of the existing Document your Guiding Principles. I am not saying that both are after exactly the same but there might be some overlap. Curious to hear your perspective on this.

Interesting. I did not know that pattern so far. You are right, there is an overlap to the strategy pattern since both are mentioning the purpose of introducting InnerSource to an organization. Since this is the first pattern that I write, I am not sure how patterns are normally tailored at ISC. One possibility that I see is to adjust "Documenting your guilding principles" in a way that it focusses on the principles (and not the purpose - anyway the main part of the pattern is about principles). Purpose and the connection of InnerSource to the goals of an organization and its (business) strategy could be covered in "Creating an InnerSource strategy". Then, both patterns would nicely complement each other - at least IMO.

Your idea sounds good too me. Let's keep your PR here as a separate pattern. Covering the connection of InnerSource to the goals of an organization and its (business) strategy would surely be great new content to have. The more specific we can make this pattern about that area the better :)

Since it's about goals and (business) strategies of organizations, it is not that easy to be specific since these things are most likely internal/confidential. But I agree to you, we should be as specific as possible.

spier commented 4 months ago

Since it's about goals and (business) strategies of organizations, it is not that easy to be specific since these things are most likely internal/confidential. But I agree to you, we should be as specific as possible.

We could possibly use an imaginary org and strategy? And then explain the solution suggested in this pattern based on that example? Would require some story telling but could work.

spier commented 2 months ago

@misappi I hope my comments on this PR did not get you disheartened to continue working on this pattern? :)

As your PR describes a pattern in the "Initial" stage, we can take shortcuts if you like, to get this PR merged in some shape or form, to at least get the pattern integrated in our repo. That will increase discoverability by others.

Then you (and others) can continue to improve this pattern in further PRs afterwards.

I am also saying that as I would like to prevent this PR from going stale.

misappi commented 2 months ago

@misappi I hope my comments on this PR did not get you disheartened to continue working on this pattern? :)

Not at all. I just had no time to work on it.

As your PR describes a pattern in the "Initial" stage, we can take shortcuts if you like, to get this PR merged in some shape or form, to at least get the pattern integrated in our repo. That will increase discoverability by others.

Then you (and others) can continue to improve this pattern in further PRs afterwards.

I am also saying that as I would like to prevent this PR from going stale.

That make sense. Would be great if you could do that. Thanks!

welcome[bot] commented 2 months ago

Congratulations Banner Congrats on merging your first pull request! :tada: We here at The InnerSource Commons are proud of you! :sparkling_heart: Thank you so much for your contribution :gift:

spier commented 2 months ago

I made minor changes but could not push those back to your branch due to a permission issue:

To github.com:misappi/InnerSourcePatterns.git
 ! [remote rejected] misappi/main -> misappi/main (permission denied)
error: failed to push some refs to 'github.com:misappi/InnerSourcePatterns.git'

Therefore I pushed straight to main myself.

This pattern draft is now available here: https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/patterns/1-initial/creating_an_innersource_strategy.md

Let's continue the conversation on slack and in future PRs 🥳

misappi commented 2 months ago

Thanks, @spier. Let's do so.