InnerSourceCommons / InnerSourcePatterns

Proven approaches that can guide you through applying open source best practices within your organization
https://patterns.innersourcecommons.org
Creative Commons Attribution Share Alike 4.0 International
728 stars 177 forks source link

chore: change either to any #668

Closed jmeridth closed 3 months ago

jmeridth commented 3 months ago

In its current context, there are 3 choices so any is more appropriate. either is for binary decisions (between 2 choices).

welcome[bot] commented 3 months ago

Thank You Banner

:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! :checkered_flag:

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

welcome[bot] commented 3 months ago

Congratulations Banner Congrats on merging your first pull request! :tada: We here at The InnerSource Commons are proud of you! :sparkling_heart: Thank you so much for your contribution :gift:

jmeridth commented 3 months ago

@spier Yes. Contribution process was very easy. Thank you. I'm re-reading the entire patterns book again and may have other PRs. This one was the gateway PR and felt very nitpicky but thank you for merging it. Cheers.

spier commented 3 months ago

That's great @jmeridth. Looking forward to any and all contributions that you want to make.

And no worry about nitpicking, if we really don't want to make a change that you are suggesting, we can just talk about that in any future PRs. No harm done, quite the opposite actually, as it is always great to have somebody with fresh eyes read our patterns again!

spier commented 3 months ago

Btw your change is not live in https://patterns.innersourcecommons.org/p/common-requirements yet. Not sure how much delay we should expect there. Will confirm with the gitbook service (which is where we are hosting our book).