InnerSourceCommons / InnerSourcePatterns

Proven approaches that can guide you through applying open source best practices within your organization
https://patterns.innersourcecommons.org
Creative Commons Attribution Share Alike 4.0 International
728 stars 177 forks source link

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files #680

Closed raivenra closed 2 months ago

raivenra commented 2 months ago

Grammatical modifications added to the Galician translation in the texts of the corresponding .md files.

welcome[bot] commented 2 months ago

Thank You Banner

:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! :checkered_flag:

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

welcome[bot] commented 2 months ago

Congratulations Banner Congrats on merging your first pull request! :tada: We here at The InnerSource Commons are proud of you! :sparkling_heart: Thank you so much for your contribution :gift:

spier commented 2 months ago

These changes are now live: https://patterns.innersourcecommons.org/v/gl

Great job @raivenra and @psanxiao !

spier commented 2 months ago

@psanxiao one question: I noticed that the first letter in the Patlet of the translated patterns was changed to lowercase. I assume that was done to achieve the desired formatting in toc.md?

galego-toc

However this also means that when opening the pattern itself, it will look like this. Is this intended and correct in Galician to start a sentence with a lower case letter?

galego-patlet-modifications

psanxiao commented 2 months ago

Good point @spier . Changes are made because of TOC, correct. In the TOC, descriptions should be in lowercase in Galician, but as you pointed out, Patlets should start in uppercase since you're right, sentences in Galician start in uppercase.

I guess there is no a good solution for this with the current configuration of the repository. As lesser of two I think it would be better Patlets start in uppercase. Sorry about not realize of that. I have to make some other minor change nexts days so I could take advantage of it and make that change...

Or you think it would be better remove the commit of the PR from main branch and make another one taking this into account?

spier commented 2 months ago

I would revert the commit(s) that lowercased the Patlets first, as that will be rather quick.

And then make the other changes in another PR.

But up to you.