Closed spriya-m closed 3 days ago
:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.
If you are submitting a new pattern, the following things will help get your pull request across the finish line! :checkered_flag:
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.
@MaineC , thank you very much for your review and comments. Really appreciate it.
@spier , thank you very much for your comments and review. I really appreciate it. I have addressed/answered your comments. Please check and let me know if you need more information.
Do you think it qualifies for 2-structured category of patterns? :)
@spier , thank you very much for your comments and review. I really appreciate it. I have addressed/answered your comments. Please check and let me know if you need more information.
Do you think it qualifies for 2-structured category of patterns? :)
Hi @spriya-m.
Technically the pattern would already qualify as 2-structured, as there is an (anonymous) known instances.
However when new patterns are proposed, we do recommend that they stay in 1-initial for a while, allowing us to harden the quality over time by getting some more eyeballs from the community on it.
I left some more comments. Just see if those are helpful.
Also, could you check if you have allowed code contributions to your PR? I was trying to push a commit through git but could not do so. Thank you.
I think we should try get this pattern merged pretty quickly, and do further improvements in future PRs. Iterations for the win :)
@spier , thank you very much for your comments and review. I really appreciate it. I have addressed/answered your comments. Please check and let me know if you need more information. Do you think it qualifies for 2-structured category of patterns? :)
Hi @spriya-m.
Technically the pattern would already qualify as 2-structured, as there is an (anonymous) known instances.
However when new patterns are proposed, we do recommend that they stay in 1-initial for a while, allowing us to harden the quality over time by getting some more eyeballs from the community on it.
I left some more comments. Just see if those are helpful.
Also, could you check if you have allowed code contributions to your PR? I was trying to push a commit through git but could not do so. Thank you.
I think we should try get this pattern merged pretty quickly, and do further improvements in future PRs. Iterations for the win :)
Hi @spier , sure no problem. This pattern can be in 1-initial category for now.
I have already enabled 'Allow edits by maintainers' and have now added you as a collaborator to the fork. I guess you should be able to commit changes now.
Please let me know if anything needs to be updated in the content. Some of the comments are like discussion and I am not sure if I need to update the content. Please let me know.
Hi @spier , sure no problem. This pattern can be in 1-initial category for now.
I have already enabled 'Allow edits by maintainers' and have now added you as a collaborator to the fork. I guess you should be able to commit changes now.
Please let me know if anything needs to be updated in the content. Some of the comments are like discussion and I am not sure if I need to update the content. Please let me know.
Strange, I can still not push to your branch. Possibly because that would mean making commits to your main
branch and there is some protection in place?
Either way, I can work around this. Will now merge this branch, and then make changes to the content in the upstream repo directly.
Thank you @spriya-m for contributing the InnerSource Hackathon pattern :)
The pattern is now available in the main repo here.
I am leaving the discussion threads open on this pattern, so that we can review them again when upgrading this pattern to the next maturity level in the future.
Feel free to share this pattern wherever you like. The more eyeballs we can get onto this, the better!
Thanks again 💐
Hi, I would like to propose a new pattern called InnerSource Hackathon.
For organizations looking for scaling InnerSource or driving InnerSource ways of working among the engineering community, such an event would help to not only spread the word about InnerSource faster but also provide a safe environment to try out InnerSource ways of working.
Please let me know your comments.