search

InnerSourceCommons / archive.innersourcecommons.org

The old version of the ISC site
Creative Commons Attribution Share Alike 4.0 International
40 stars 29 forks source link

Tabs or Spaces? #101

Open dellagustin opened 4 years ago

dellagustin commented 4 years ago

Currently there is a mixed usage of tabs and spaces on the webpage files. It would be good to start defining the rules and document them in the contribution guidelines.

I personally prefer tabs, and support the arguments raised by Lea Verou in her article Why tabs are clearly superior.

rrrutledge commented 4 years ago

This is a great question, @dellagustin. Why don't you represent this topic in #tech-infra to get a discussion and some direction?

dellagustin-sap commented 4 years ago

Linking back to the corresponding slack thread: https://innersourcecommons.slack.com/archives/CGSE508A1/p1582562709013200

lenucksi commented 4 years ago

I'm fine with Tabs. Some consistency and linting would probably not harm anyone and might help others.

marshmallowrobot commented 4 years ago

The correct answer to tabs vs spaces is: the one that you enforce.

It really makes no difference which you choose. So long as everyone uses an editor that can support an .editorconfig file, we'll all have the same settings. As files get touched over time, this problem will solve itself. We could also use a linter to enforce our preference as a build step, so that PRs dont get merged that don't follow the spacing rules.