search

InnerSourceCommons / archive.innersourcecommons.org

The old version of the ISC site
Creative Commons Attribution Share Alike 4.0 International
40 stars 29 forks source link

Added event - InnerSource day at OSCON 2019 #118

Closed dellagustin-sap closed 4 years ago

dellagustin-sap commented 4 years ago

I added InnerSource day at OSCON 2019 to past events.

Local test: image

I also did a minor adjustment to the text of ISC Summit 5, adding an extra dash to have the same patters as the others.

I took the event url and created a snapshot at web.archive.org, to prevent from having a broken link in the future (it may break, but we have a fallback :D) This practice should become a Best-practice (maybe add it to the contribution guideline).

rrrutledge commented 4 years ago

Love it! Looks great!

dellagustin commented 4 years ago

Thanks for approving, can you merge it as well?

rrrutledge commented 4 years ago

I can. I am leaving it open for a week for anyone else to weigh in since we ourselves were not the sponsors of InnerSource Day, just sent a lot of speakers to it. I have a reminder set to check on this PR next week and make sure it has gotten feedback and finished.

maxcapraro commented 4 years ago

I can. I am leaving it open for a week for anyone else to weigh in since we ourselves were not the sponsors of InnerSource Day, just sent a lot of speakers to it. I have a reminder set to check on this PR next week and make sure it has gotten feedback and finished.

This is a valid point. Maybe the suggested change can be an easy fix?

I feel much more comfortable with (retrospectively) advertising an event hosted by a renowned publisher, than advertising for example an event by a commercial player in the field. But that's just my two cents.

dellagustin-sap commented 4 years ago

Hi @maxcapraro , I have added your suggestion with 377dd849a8c4b23d9dfed6c6c637907649df1885.

maxcapraro commented 4 years ago

Excellent and thanks a bunch @dellagustin-sap <3