search

InnoZ / MAS_Interface

Apache License 2.0
1 stars 0 forks source link

replacing 'Landkreis' with 'Kreis' #82

Closed 00Bock closed 6 years ago

00Bock commented 6 years ago

ready to merge. should be working but specs are failing. they were beforehand as well but maybe we need to fix them sooner or later.

BenSto commented 6 years ago

Btw you can assign/close an Issue directly with your Pull Request by saying closes #78 But I can not really see how that closes the Issue... because now everything will just be called a 'Kreis' but IMO that's also wrong to call a kreisfreie Stadt 'Kreis' even if its better than Landkreis. So to really solve the Issue there has to be a distinction between all units that are kreisfrei and the units that are Kreis.. or am I wrong?

00Bock commented 6 years ago

no, 'Kreise' is regularly used to include both types e.g. at INKAR and BBSR. so please don't be so stingy :)

but I guess you are somehow right because it's not really an elegant solution. but I do not want to create a german-specific solution. one option would be to receive an entry from the districts table from a column called district_type and set default entry to district and update the values according to regional admin type. alternatively we can find a word which is global enough to include any type of district e.g. 'administrative Einheit'.

00Bock commented 6 years ago

would also be good to address special needs like 'Region Hannover'.

BenSto commented 6 years ago

no, 'Kreise' is regularly used to include both types e.g. at INKAR and BBSR. so please don't be so stingy :)

that's not stingy, just wanted to ensure that the quality gets better. In fact I didn't know that with BBSR and INKAR. So please go ahead, I think it's a good solution. :+1:

One other thing, how do we want to treat this tool in the nearer future as we don't have any matsim expert anymore at the innoz?

BenSto commented 6 years ago

merge? @kjoscha