Vue 3 Support - Githubissues

Innologica / vue2-daterange-picker

Vue2 date range picker

https://innologica.github.io/vue2-daterange-picker/

MIT License

330 stars 209 forks source link

Vue 3 Support #264

Open hisuwh opened 3 years ago

hisuwh commented 3 years ago

Are there any plans to support Vue 3 with this package?

nkostadinov commented 3 years ago

well there are plans :), but I don't how to handle both versions because I dont want to make separate component for vue 3

hisuwh commented 3 years ago

@nkostadinov have you seen this: https://github.com/vueuse/vue-demi

nkostadinov commented 3 years ago

@hisuwh looks like what I need, I will check it :) 10x

davolcu commented 2 years ago

Any updates on this issue? Vue 3 is the new recommended version of Vue, but there's no support still

ghrapan commented 2 years ago

@nkostadinov Since I needed the daterange picker for Vue 3 asap, I have forked and upgraded your codebase to Vue 3, Vite and VuePress v2 - https://github.com/EntryPointDev/vue3-daterange-picker

All original tests are passed.

A few things to note:

I didn't want to use Vue-demi, so it is a separate version of component
JSON doc generation for components is currenly missing, as @vuedoc/parser doesn't support the Vue 3 yet

Would you be interested in PR? If so, please create a separate branch for Vue 3 version, so I could use it as a base branch when creating a PR.

gabstafari commented 2 years ago

@nkostadinov Since I needed the daterange picker for Vue 3 asap, I have forked and upgraded your codebase to Vue 3, Vite and VuePress v2 - https://github.com/EntryPointDev/vue3-daterange-picker

All original tests are passed.

A few things to note:

I didn't want to use Vue-demi, so it is a separate version of component

JSON doc generation for components is currenly missing, as @vuedoc/parser doesn't support the Vue 3 yet

Would you be interested in PR? If so, please create a separate branch for Vue 3 version, so I could use it as a base branch when creating a PR.

@ghrapan

It works nicely! but the appendToBody doesn't seem to work.

ghrapan commented 2 years ago

@nkostadinov Since I needed the daterange picker for Vue 3 asap, I have forked and upgraded your codebase to Vue 3, Vite and VuePress v2 - https://github.com/EntryPointDev/vue3-daterange-picker All original tests are passed. A few things to note:

I didn't want to use Vue-demi, so it is a separate version of component

JSON doc generation for components is currenly missing, as @vuedoc/parser doesn't support the Vue 3 yet

Would you be interested in PR? If so, please create a separate branch for Vue 3 version, so I could use it as a base branch when creating a PR.

@ghrapan

It works nicely! but the appendToBody doesn't seem to work.

@gabstafari Sorry, missed your PR. I've pushed a fix.

lk77 commented 2 years ago

Hello,

i've tried your fork and appendToBody does not seems to work :

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'appendToBody')
    at inserted (appendToBody.js?d7a7:3:1)

did you publish a new version on npm after the pull request ?

ghrapan commented 2 years ago

Hello,

i've tried your fork and appendToBody does not seems to work :
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'appendToBody')
    at inserted (appendToBody.js?d7a7:3:1)
did you publish a new version on npm after the pull request ?

Hello,

Yes I did, it's version 0.1.2. The error message strongly suggests that you're using the previous version.

lk77 commented 2 years ago

mm it's seems i installed the wrong package, https://www.npmjs.com/package/vue3-daterange-picker instead of https://www.npmjs.com/package/vue3-gabe-daterange-picker

thanks

viswa1989 commented 2 years ago

Is there any alternative or support for vue3. Please comment

rdhainaut commented 1 year ago

I have appreciated this library. But now for vue 3, i will switch to https://vue3datepicker.com

Note: for the preset range see