Innologica / vue2-daterange-picker

Vue2 date range picker
https://innologica.github.io/vue2-daterange-picker/
MIT License
330 stars 209 forks source link

This dependency was not found: * Vue #68

Closed damonjanis closed 5 years ago

damonjanis commented 5 years ago

Is there some extra configuration required to get vue2-daterange-picker to compile with webpack? I get this error when it compiles:

This dependency was not found: in ./node_modules/vue2-daterange-picker/dist/lib/vue-daterange-p.min.js To install it, you can run: npm install --save Vue

Vue is already installed so confused on this one.

nkostadinov commented 5 years ago

I removed the vue and moment libs from the bundle and this is causing the problem. Seems the same as #66 . I merged the pull request so now it should be fine.

Is it possible to test it from the master branch if it is ok with you now.

damonjanis commented 5 years ago

Thanks @nkostadinov for looking at it. That does partially solve it, but there is still a compile issue. vue-daterange-picker-min.js script is referring to 'Vue' in several places and should be referring to 'vue'. If all Vue occurrences in that script file are replaced with vue I think it will compile correctly.

nkostadinov commented 5 years ago

I just bumped the version to 0.2.5 and recompiled the lib. I think it should be ok now

damonjanis commented 5 years ago

That works perfectly, thanks for putting this component together!