InnovateAsterisk / Browser-Phone

A fully featured browser based WebRTC SIP phone for Asterisk
https://www.innovateasterisk.com
GNU Affero General Public License v3.0
499 stars 245 forks source link

Call transfer: default action for quicker user experience #384

Open vieridipaola opened 1 year ago

vieridipaola commented 1 year ago

Hi,

As mentioned here: https://github.com/InnovateAsterisk/Browser-Phone/issues/349

it would be nice to have a default transfer type to be triggered when trying to transfer a call.

In my scenario, users usually just blind-transfer, and only a few require attended transfers.

I'm having a hard time myself deciding how to quicken the process for those heavy-duty users having to transfer a lot of calls.

If you could update phone.js with:

function QuickFindBuddy(obj, lineNumber){

and then maybe add a custom web hook for the select event:

[...]
    if(items.length > 1){
        var menu = {
            selectEvent : function( event, ui ) {
                var number = ui.item.attr("value");
                if(number == null) HidePopup();
                if(number != "null" && number != "" && number != undefined) {
                    HidePopup();
                    obj.value = number;
                    // if user selects buddy then blind transfer call:
                    BlindTransfer(lineNumber);

so I can call the BlindTransfer function in my custom js instead of doing so in phone.js.

Or maybe you could add a phoneOptions setting to control whether the default action on selecting a buddy is to call BlindTransfer or not.

InnovateAsterisk commented 1 year ago

Keyboard shortcuts are on their way, but will be a configurable matrix of shortcuts. Thing like transfer and blind transfer will be via these shortcuts - so like Blind Transfer and Attended Transfer will be something like [Ctrl] + t or [Ctrl] + [Shift] + t

vieridipaola commented 1 year ago

Nice.

vieridipaola commented 1 year ago

I also noticed that the contact information can sometimes overlap and hide the transfer buttons especially when the caller ID/buddy text is long. The transfer buttons should never be hidden underneath the autocomplete list. Shortcuts are coming soon, but in the meantime the transfer buttons could be moved "above" the contact autocomplete dropdown, or both blind and attended transfer buttons could be included right next to each auto-completed contact in the dropdown...

InnovateAsterisk commented 1 year ago

Can you send a screenshot of what you are seeing

vieridipaola commented 1 year ago

Sure:

image

vieridipaola commented 1 year ago

I also noticed that the presence state is not updated once the drop-down menu is shown, ie. if you see your buddies while typing their extensions before transferring and in the meantime their state changes, it is not reflected here. I guess you'd have to rewrite the buddy number or name to refresh the dropdown. Anyway, this may be really too much to ask....

InnovateAsterisk commented 1 year ago

I would like to solve the UI (and the updating) via a new feature, or improvement to the UI. (I don't like the little popup, its not very user friendly). After the upgrade, clicking Transfer will change the UI to something like the other call action screens, so that you have the full UI to perform search, etc.

vieridipaola commented 1 year ago

Great!