Innovateninjas / Paws-frontend

A fast responsive webapp that allows you to report injured stray animals to the nearest NGOs.
https://pawss.vercel.app
GNU General Public License v3.0
63 stars 101 forks source link

#279 contact information page made responsive #334

Closed Riddhi162 closed 5 months ago

Riddhi162 commented 5 months ago

Description

[Please include a brief description of the changes or features added] I have made the contact details page completely responsive.For all the screens it is responsive.

Related Issue

279

Screenshots / GIFs (if applicable)

[Attach any relevant screenshots or GIFs demonstrating the changes] BEFORE: Screenshot 2024-05-15 020112 AFTER: Screenshot 2024-05-14 234249

Checklist:

Additional Notes

[Add any additional notes or context about the changes made]

rishicds commented 5 months ago

Hi, please make the size of both buttons same, otherwise good work, itll be merged after that, also is it responsive on desktop?

codewarnab commented 5 months ago

@Riddhi162 add screenshot for desktop

Riddhi162 commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645

I also made the button size same

Riddhi162 commented 5 months ago

Hi @Riddhi162 please update your branch and attach a screenshot of desktop

I edited the files here only and made the button size similar.Please check the commits.

codewarnab commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645

I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

codewarnab commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645

I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

Also make the buttons bigger and add space between them in desktop

Riddhi162 commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645 I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

codewarnab commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645 I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts

Riddhi162 commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645 I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts

Done.

codewarnab commented 5 months ago

@Riddhi162 add screenshot for desktop

Sure Screenshot 2024-05-17 004141 Screenshot 2024-05-17 005645 I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts

Done.

can you please add another screenshot how its looking now for mobile and desktop

Riddhi162 commented 5 months ago

Screenshot 2024-05-20 003302 Screenshot 2024-05-20 003322

codewarnab commented 5 months ago

Screenshot 2024-05-20 003302 Screenshot 2024-05-20 003322

I told you to add space in the desktop mode not in the mobile , also buttons are looking smaller than before in mobile

Riddhi162 commented 5 months ago

image Okay made the changes for mobile view

codewarnab commented 5 months ago

thank you good job will be merged soon

codewarnab commented 5 months ago

@rishicds