Innovateninjas / Paws-frontend

A fast responsive webapp that allows you to report injured stray animals to the nearest NGOs.
https://pawss.vercel.app
GNU General Public License v3.0
60 stars 99 forks source link

form issue #275 #341

Closed siddxharth1 closed 3 months ago

siddxharth1 commented 4 months ago

Description

form validations added and navbar labels

Related Issue

Issue #275

Screenshots / GIFs (if applicable)

image added names in the navbar in home page

Checklist:

Additional Notes

[Add any additional notes or context about the changes made]

codewarnab commented 4 months ago

@siddxharth1 how it shows if strenth is strong ? try to add all the states screenshots

codewarnab commented 4 months ago

@siddxharth1 what did you changed in navbar ?

siddxharth1 commented 4 months ago

@siddxharth1 how it shows if strenth is strong ? try to add all the states screenshots

i have added a function in util which takes the password string and returns a strength string a password is very strong if password.length >= 8 && hasUpperCase && hasLowerCase && hasNumber & hasNonAlphanumeric is strong if password.length >= 8 && hasUpperCase && hasLowerCase && hasNumber is medium if password.length >= 8 && ((hasUpperCase && hasLowerCase) or hasNonAlphanumeric) else it is weak Ex: Abcdfgh1@ : very strong Abcdfgh1: strong abcdfgh@ or Abcdfgh1 : medium else weak

and in the navbar i have added the label image as you can see there is no label here to which page it will redirect so i have added the label also

codewarnab commented 4 months ago

@siddxharth1 no need of this also discussed here #320 discard those changes also

  1. in your pr google auth code is not their check the diff tin the file chanaged section probabaly try to incoporate them
  2. in your code all the single quotes( ' ) is changed into double quotes( " ) fix this we prefer single

then it will be good to merge thank you !