search

InnovativeInventor / docker-pivpn

A secure docker container that sets up PiVPN in a virtual environment.
MIT License
90 stars 17 forks source link

Does not build ! Wrong docker build command and file/folder existence checks #6

Open Aquillum opened 6 years ago

Aquillum commented 6 years ago

I tried the setup script but I could not build the Dockerfile.

*) The build command is wrong: docker build -t innovativeinventor/docker-pivpn:$tag $tag/Dockerfile it should be docker build -f $tag/Dockerfile -t innovativeinventor/docker-pivpn:$tag .

*) The checks for the existence of Dockerfile and setup_repo() { if [ -e docker-pivpn are in wrong folders, also the git clone. I can try to fake that with creating a Dockerfile in the setup.sh folder and a docker-pivpn folder inside.

*) install.sh is called 2 times !

*) the sed --> Default.txt fails, that file is not in that folder

InnovativeInventor commented 6 years ago

I'll check this stuff out. Although, the install.sh being called 2 times was not a mistake. There was an issue with the pivpn script and I had to call it twice. I'll be trying to remove it (because it does look sloppy). If you want to submit a pull request, I'll be happy to see your changes!