Fix build on armhf - Githubissues

InnovativeInventor / docker-pivpn

A secure docker container that sets up PiVPN in a virtual environment.

MIT License

90 stars 17 forks source link

Fix build on armhf #9

Closed mje-nz closed 6 years ago

mje-nz commented 6 years ago

I had a go at getting this to work on a Raspberry Pi 3. This is as far as I got -- it builds, but I gave up after this and I'm going to use another machine instead.

InnovativeInventor commented 6 years ago

Thanks for the contribution! All development is on the devel branch. I"m away from home, so I can't test your modified Dockerfile this week, but I'll get to it as soon as I can.

mje-nz commented 6 years ago

Oh sorry, I didn't see that your devel branch is ahead, this commit is probably not that helpful then.

Having said that:

It's considered bad practise to base your image on a "latest" tag as it will change out from under you in the future (I used debian:stretch instead).
You also shouldn't have "RUN apt-get update" as a standalone command as it'll give you cache problems (see the best practises guidelines).
It's a good idea to clear the apt cache after running package installs.

InnovativeInventor commented 6 years ago

Thanks for the feedback, I've fixed the issues that you've mentioned in the devel branch. Feel free to continue helping this project!