InnovativeOnlineIndustries / Emojiful

Emojis in minecraft!
MIT License
28 stars 26 forks source link

Client hang for several seconds whilst typing block/item ID or scoreboard criterion in command #77

Open James103 opened 1 year ago

James103 commented 1 year ago

In heavily modded instances with many thousands of block and item IDs, typing a command such as setblock 1 2 3 stone, give @s egg or scoreboard objectives add ... may cause the client to hang for several seconds whilst getting and rendering the list of possible block IDs, item IDs and scoreboard criterion respectively.

To reproduce:

  1. Install the mod pack "All of Fabric 6" version 1.5.0 or 1.5.1, which contains Emojiful 4.0.4.
  2. Create a new world with cheats enabled.
  3. Start typing the command: scoreboard objectives add test dummy
  4. Right after typing the word test, the client hangs for several seconds.

Even though the above steps caused the hang for me (in 1.19.2), the underlying cause means the issue should still exist with Emojiful 4.1.0 if enough other content mods are also installed on the same Minecraft 1.19.3 instance.

Spark profiler report showing this mod is causing the issue: https://spark.lucko.me/OLINd2WHb2