Innoxia / liliths-throne-public

Public repository for Lilith's Throne. (18+)
Other
501 stars 433 forks source link

missing dependency to `javafx*` in `pom.xml` prevents build on non-EOLed java versions #1435

Open nonchip opened 4 years ago

nonchip commented 4 years ago

Since JavaFX isn't packaged in Java for any modern version, there needs to be a maven dependency for it to make it build on anything newer than oracle's EOLed jdk8 which expired in 2014 already.

(yes, even on modern oracle jdks javafx isn't too much of a thing anymore and at least deprecated, see also)

something like this in <project> in the pom.xml seems to suffice (builds on my machine™, using openjdk11):

<dependencies>
  <dependency>
     <groupId>org.openjfx</groupId>
     <artifactId>javafx-controls</artifactId>
     <version>15</version>
  </dependency>
  <dependency>
     <groupId>org.openjfx</groupId>
     <artifactId>javafx-fxml</artifactId>
     <version>15</version>
  </dependency>
  <dependency>
     <groupId>org.openjfx</groupId>
     <artifactId>javafx-web</artifactId>
     <version>15</version>
  </dependency>
</dependencies>
the-b-rye commented 4 years ago

FWIW, Zulu still provides updated versions of Java w/ JavaFX bundled.

https://www.azul.com/downloads/zulu-community/?architecture=x86-64-bit&package=jre-fx

lilalesbian commented 3 years ago

After an hour of trying to make the game run because of the missing JavaFX, I managed to start it with JDK 8 from Liberica: https://bell-sw.com/pages/downloads/ Maybe anyone else finds this helpful :) Just select the FULL JDK version for JavaFX to be included