Innoxia / liliths-throne-public

Public repository for Lilith's Throne. (18+)
Other
477 stars 434 forks source link

Milking room assignments not working #721

Open Innoxia opened 6 years ago

Innoxia commented 6 years ago

Please give the ability to reliably assign slaves to milking rooms. Current system just doesn't do it properly. I'm sick and tired that my cows whose goods are intended for selling wander into a wrong milking room which I use for storage and my addiction cure.

pokerface17 commented 6 years ago

i just notice something is wrong with milk room. try to build and then empty the milking room. then go to slave to assign the slave. look at the limit. if this is working then it should show there is 8 more space to put into dairy cow. this is from exe ver 0.2.6.2

DerMaskierte commented 5 years ago

I have experienced issues with this too.

I have set several rooms, but the slave assigned to milking will just not go there. There are milking events in slavery overview, but the slave in never in the milking rooms, and all the milking storages are empty.

When assigned to other jobs they will do them properly. This only affects slaves set to be milked.

DerMaskierte commented 5 years ago

Upon further testing, the slave was using their salve quarters as a milking room. It may have been a side-effect of the bug that prevents placing quad rooms.

I moved the slave to a different room, turned the room into a milking room, and there they were all the milked liquids.

Edit:

Checking the save files, it looks like the game is keeping milking room settings and storage values after a milking room is removed:

  <slavery generatedIncome="0" generatedUpkeep="0">
    <milkingRoom autoSellCum="false" autoSellGirlcum="false" autoSellMilk="false" worldType="LILAYAS_HOUSE_GROUND_FLOOR" x="4" y="7"/>
  </slavery>

That room at (4,7) was no longer a milking room. Deleting the line solved the issue. The slaves properly moved to existing milking rooms.

I'd recommend preventing removing a milking room until all milk stored in it is sold or removed, and clearing any milking room data tied to it once removed.