Is the data structure for animations correct?

Inochi2D / inochi2d

Inochi2D reference implementation aimed at rendering 2D puppets that can be animated in real-time (using eg. facial capture).

BSD 2-Clause "Simplified" License

1.25k stars 47 forks source link

Is the data structure for animations correct? #40

Closed helloar14 closed 1 year ago

helloar14 commented 1 year ago

In the current data structure for animations:

Animations is an object;
Each animation is a property with the property name same as Animation name.

If we refer to parameters, shouldn't this be:

Animations is an Array of Object;
Each object has properties which is timestep, animationWeight, lanes, etc... AND animationName.

This way parameters, animations and bindings from Session will have a somewhat consistent structure.

LunaTheFoxgirl commented 1 year ago

Animation being indexed by name is more an optimization thing, but yeah, we should probably chose to write one or the other out to file instead of both...

LunaTheFoxgirl commented 1 year ago

After looking through it, the data structure is as intended. The reason being is that Animations use their name as a key, as such the key should be unique. Parameters on the other hand is indexed by their UUID, as such multiple parameters can share a name.