Closed guibranco closed 2 months ago
⏱️ Estimated effort to review [1-5] | 1, because the changes are straightforward and involve the addition of a new configuration file without complex logic. |
🧪 Relevant tests | No |
⚡ Possible issues | No |
🔒 Security concerns | No |
Category | Suggestion | Score |
Best practice |
Change single quotes to double quotes for string values for consistency___ **Consider using double quotes for the string values in the allowlist paths and regexes forconsistency and to avoid potential parsing issues.** [.infisical-scan.toml [8-12]](https://github.com/InovacaoMediaBrasil/Intranet/pull/70/files#diff-b667489620546dac1e4634848e7cf2a622d515a993530e19097573d111759084R8-R12) ```diff -paths = ['''(.*?)\.js'''] -regexes = ['''listaDeCompras_token'''] +paths = ["(.*?)\\.js"] +regexes = ["listaDeCompras_token"] ``` Suggestion importance[1-10]: 8Why: The suggestion addresses consistency in string formatting, which is a good practice in TOML files, and it helps avoid potential parsing issues, making the code more maintainable. | 8 |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Infisical secrets check: :white_check_mark: No secrets leaked!
Scan results:
12:13PM INF scanning for exposed secrets...
12:13PM INF 80 commits scanned.
12:13PM INF scan completed in 217ms
12:13PM INF no leaks found
Description
.infisical-scan.toml
file for configuration.ReadOnlyToken
.extend
section to use default settings.Changes walkthrough 📝
.infisical-scan.toml
New configuration file for Infisical scan
.infisical-scan.toml