search

InovelliUSA / OpenZWave

Location for Inovelli open-zwave configuration files
Apache License 2.0
26 stars 19 forks source link

Merge LZW31(-SN) upstream #5

Open uSpike opened 4 years ago

uSpike commented 4 years ago

Hi, I'd just like to request that the LZW31(-SN) configs be merged into upstream open-zwave. I'm currently testing my LZW31-SN with the config here, but I'd really like to go back to upstream configuration! Thanks!

mdallaire commented 4 years ago

It looks like a PR was created in January, However @InovelliUSA has yet to address the requested review/changes for it to get merged. https://github.com/OpenZWave/open-zwave/pull/2077

Fishwaldo commented 4 years ago

If someone can confirm the lzw31-sn works without the CentralScene Block in the config file, I'm happy to merge manually. Just need someone to test it out.

cts1085 commented 4 years ago

I have a LZW31-SN with OZW 1.6 - it appears to work without the CentralScene block - it would be really nice to have LZW31-SN in the official config repository....

mdallaire commented 4 years ago

I have a LZW31-SN with OZW 1.6 - it appears to work without the CentralScene block - it would be really nice to have LZW31-SN in the official config repository....

I just tested this too and detailed my results here: https://github.com/OpenZWave/open-zwave/pull/2077#issuecomment-594653395 @Fishwaldo I think you can merge manually but let me know if you want more testing.