search

Inpacchi / Manga-Tagger

The only tool you'll need to rename and write metadata to your digital manga library
MIT License
167 stars 6 forks source link

[BUG] v1.1.2-alpha Fails to Start #22

Closed Ablex222 closed 3 years ago

Ablex222 commented 3 years ago

OS: What operating system are you running Manga Tagger on? Windows 10 Manga Tagger Version: What version of Manga Tagger are you running? v1.1.2-alpha Description of the issue: Give a a clear and concise description of what the issue is. Starting new version once selecting FMD folder proceeds to crash and give error. Manga Series: What manga series (singular or plural) were being tagged when the issue was encountered?

Screenshots (If applicable): Add screenshots to help explain your problem. image

Log File: Please make sure JSON logging is enabled and upload the JSON log file.

Inpacchi commented 3 years ago

Ah, I overlooked a setting in the settings.json. This is a quick fix; will handle it later today.

On January 15, 2021 at 7:48:33 AM, Ablex222 (notifications@github.com(mailto:notifications@github.com)) wrote:

Assigned #22(https://github.com/Inpacchi/Manga-Tagger/issues/22) to @Inpacchi(https://github.com/Inpacchi).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub(https://github.com/Inpacchi/Manga-Tagger/issues/22#event-4211012083), or unsubscribe(https://github.com/notifications/unsubscribe-auth/ACUOWAT6UVKRQU6FKVU4YZTS2A2SDANCNFSM4WEAHYJQ).

Ablex222 commented 3 years ago

Was wondering if this got resolved?

Inpacchi commented 3 years ago

Meant to respond to this yesterday but had to run out the door. I did start working on it, and was in the middle of QAing before I had to stop for the night, and then the weekend happened and you know how that goes.

I picked up work on this last night (I actually was streaming my bug fixing) and made some good progress. It was originally going to be a quick fix however, when I QA’d (because I forgot to QA the start up process; I only QA’d the other changes I made) I noticed that FMD wasn’t opening or closing. I’m currently in the middle of debugging that and making sure FMD closes as it should before Manga Tagger continues to do anything; otherwise the application won’t work correctly.

On January 18, 2021 at 8:11:21 AM, Ablex222 (notifications@github.com(mailto:notifications@github.com)) wrote:

Was wondering if this got resolved?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(https://github.com/Inpacchi/Manga-Tagger/issues/22#issuecomment-762241375), or unsubscribe(https://github.com/notifications/unsubscribe-auth/ACUOWAX24MSMHQFRU6XYYH3S2QXPTANCNFSM4WEAHYJQ).

Ablex222 commented 3 years ago

I am not 100% about the implementation, but at least with a windows client you could just use the "taskkill" cmds to force close the software before the rest of the program runs. Not pretty, but should be functional.

Inpacchi commented 3 years ago

Resolved with release v1.1.4-alpha