Closed InputUsername closed 1 year ago
@InputUsername I'll review this tomorrow evening after I get back from my job interview.
@shymega perfect, thanks! And best of luck with your job interview :smile:
@shymega perfect, thanks! And best of luck with your job interview smile
Thanks! It went great, last time it didn't go so well (virtual, and it was mostly my fault), but this time they said my professionalism, body language, and questions/answers were vastly improved, so fingers crossed!
@shymega
@InputUsername This all looks fine to me, I think we should make it clear in bold that it's a breaking change release, given a fair amount of return types have been modified, but other than that, excellent! :100:
Thanks! It definitely makes sense to indicate the breakage more clearly (even though it's not technically required), so I've added a note to the changelog.
Thanks! It went great, last time it didn't go so well (virtual, and it was mostly my fault), but this time they said my professionalism, body language, and questions/answers were vastly improved, so fingers crossed!
That's great, hoping for the best :crossed_fingers:
ListenBrainz silently changed their response schemas, this PR addresses those changes (as reported in #12).
user/{user_name}/playing-now
:UserPlayingNowPayload::playing_now
;UserPlayingNowListen::playing_now
;user/{user_name}/listens
:UserListensListen::inserted_at
fromString
toi64
.stats/sitewide/artists
:StatsSitewideArtistsPayload::time_ranges
;StatsSitewideArtistsPayload::artists
;StatsSitewideArtistsTimeRange
;StatsSitewideArtistsArtist::artist_msid
.stats/user/{user_name}/artist-map
:Client::stats_user_artist_map
fromResult<StatsUserArtistMapResponse, Error>
toResult<Option<StatsUserArtistMapResponse>, Error>
.users/{user_list}/recent-listens
:Client::users_recent_listens
;UsersRecentListensResponse
;UsersRecentListensPayload
;UsersRecentListensListen
;UsersRecentListensTrackMetadata
;examples/users_recent_listens.rs
.