InputUsername / listenbrainz-rs

ListenBrainz API bindings for Rust
https://crates.io/crates/listenbrainz
MIT License
12 stars 6 forks source link

Update response schemas to match the latest API version #13

Closed InputUsername closed 1 year ago

InputUsername commented 1 year ago

ListenBrainz silently changed their response schemas, this PR addresses those changes (as reported in #12).

shymega commented 1 year ago

@InputUsername I'll review this tomorrow evening after I get back from my job interview.

InputUsername commented 1 year ago

@shymega perfect, thanks! And best of luck with your job interview :smile:

shymega commented 1 year ago

@shymega perfect, thanks! And best of luck with your job interview smile

Thanks! It went great, last time it didn't go so well (virtual, and it was mostly my fault), but this time they said my professionalism, body language, and questions/answers were vastly improved, so fingers crossed!

InputUsername commented 1 year ago

@shymega

@InputUsername This all looks fine to me, I think we should make it clear in bold that it's a breaking change release, given a fair amount of return types have been modified, but other than that, excellent! :100:

Thanks! It definitely makes sense to indicate the breakage more clearly (even though it's not technically required), so I've added a note to the changelog.

Thanks! It went great, last time it didn't go so well (virtual, and it was mostly my fault), but this time they said my professionalism, body language, and questions/answers were vastly improved, so fingers crossed!

That's great, hoping for the best :crossed_fingers: