search

InputUsername / listenbrainz-rs

ListenBrainz API bindings for Rust
https://crates.io/crates/listenbrainz
MIT License
12 stars 6 forks source link

Implemented GET /1/stats/release-group/(release_group_mbid)/listeners #20

Closed RustyNova016 closed 7 months ago

RustyNova016 commented 7 months ago

Here's the implementation of this endpoint https://listenbrainz.readthedocs.io/en/latest/users/api/statistics.html#get--1-stats-release-group-(release_group_mbid)-listeners.

The schema need verification for more edge cases, but other than that it should be working.

By the way, the response model file is now 500 lines long. Maybe it would be better to split it up a bit?

RustyNova016 commented 7 months ago

The schema was correct all along (Or else go blame lucifer on the IRC lol)

RustyNova016 commented 7 months ago

Ooops- I merged my own fork's changes in my pull request branch instead of my own branch. I'm fixing that.

As for the doc comments, I'd say either we slowly add them to types, because while inconsistent, it's better than nothing, or else we make a new branch just for them.

InputUsername commented 7 months ago

I merged my own fork's changes in my pull request branch instead of my own branch. I'm fixing that.

:+1:

As for the doc comments, I'd say either we slowly add them to types, because while inconsistent, it's better than nothing, or else we make a new branch just for them.

New branch/PR is probably best :smile:

By the way, the response model file is now 500 lines long. Maybe it would be better to split it up a bit?

Yeah, definitely. I'll make an issue for this.

RustyNova016 commented 7 months ago

I recreated the whole branch, much easier than to git wrangle out of this mess. See #23