Closed RustyNova016 closed 5 months ago
Finally, commits need to be documented a bit more. Currently, they're just one-liners with no justification or detail. The PR desc could be improved too.
And fixed the .gitignore.
Commits should be squashed into one. Same as #24:
I would rather the last three commits are squashed into one, rebased against main, and then reworded to describe the changes. Currently, it'll lead to a somewhat confusing commit history if we merge as-is. Sorry, I'm not trying to hold up the PR - just trying to keep a easy to understand commit history.
This should be fine. It's the first time I did a Rebase and Squash like this so I hope I didn't mess up anything
Rebase is fine.
Remove the .gitiignore change
Recreation of #20 due to accidental commits