Implemented GET /1/stats/release-group/(release_group_mbid)/listeners

InputUsername / listenbrainz-rs

ListenBrainz API bindings for Rust

https://crates.io/crates/listenbrainz

MIT License

11 stars 6 forks source link

Implemented GET /1/stats/release-group/(release_group_mbid)/listeners #23

Closed RustyNova016 closed 5 months ago

RustyNova016 commented 6 months ago

Recreation of #20 due to accidental commits

shymega commented 6 months ago

Finally, commits need to be documented a bit more. Currently, they're just one-liners with no justification or detail. The PR desc could be improved too.

RustyNova016 commented 6 months ago

And fixed the .gitignore.

shymega commented 6 months ago

Commits should be squashed into one. Same as #24:

I would rather the last three commits are squashed into one, rebased against main, and then reworded to describe the changes. Currently, it'll lead to a somewhat confusing commit history if we merge as-is. Sorry, I'm not trying to hold up the PR - just trying to keep a easy to understand commit history.

RustyNova016 commented 6 months ago

This should be fine. It's the first time I did a Rebase and Squash like this so I hope I didn't mess up anything

shymega commented 6 months ago

Rebase is fine.

RustyNova016 commented 5 months ago

Remove the .gitiignore change