search

InputUsername / listenbrainz-rs

ListenBrainz API bindings for Rust
https://crates.io/crates/listenbrainz
MIT License
12 stars 6 forks source link

Update to the UserListensResponse models to add MBID mapping (No Doc) #24

Closed RustyNova016 closed 6 months ago

RustyNova016 commented 7 months ago

Here is the version without documentation for the MBID Mapping from #22. It also removes the timerange parameter as it isn't used in the API anymore.

shymega commented 7 months ago

Also, CI has failed. This needs to be resolved before merge.

shymega commented 7 months ago

Finally, commits need to be documented a bit more. Currently, they're just one-liners with no justification or detail. The PR desc could be improved too.

Maybe might be worth squashing into one commit too, if it's just for one change.

RustyNova016 commented 7 months ago

Sorry I didn't get to squash those commits while pushing the .gitignore fix. But since it's already approved by one, should it just be done while merging?

shymega commented 7 months ago

I would rather the last three commits are squashed into one, rebased against main, and then reworded to describe the changes.

Currently, it'll lead to a somewhat confusing commit history if we merge as-is.

Sorry, I'm not trying to hold up the PR - just trying to keep a easy to understand commit history.

RustyNova016 commented 7 months ago

Sorry, I was busy all week. Should be good!

RustyNova016 commented 6 months ago

Neat! Only waiting for the release now.

I'll first work on #25 now that those are merged and I'll go back to adding random stuff that I need