search

InputUsername / listenbrainz-rs

ListenBrainz API bindings for Rust
https://crates.io/crates/listenbrainz
MIT License
11 stars 6 forks source link

Update attohttpc requirement from 0.27 to 0.28 #27

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 5 months ago

Updates the requirements on attohttpc to permit the latest version.

Release notes

Sourced from attohttpc's releases.

v0.28.0

What's Changed

Full Changelog: https://github.com/sbstp/attohttpc/compare/v0.27.0...v0.28.0

Commits


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
InputUsername commented 5 months ago

@shymega

As CI has passed on this PR, I'm gonna say we can safely merge it. However, we should setup a process to determine the MSRV for this crate, so that we don't stop supporting older Rust toolchains.

Sounds good, and I agree. I've run cargo-msrv against the repo and it determined the MSRV to be 1.58.1 (released 2022-01-20). We could pin the rust-version in Cargo.toml to 1.58 and integrate cargo msrv verify in CI. It seems like we're mostly dependent on attohttpc though, which does not specify an MSRV.

Also, could you review the other open PRs?

shymega commented 5 months ago

@shymega

As CI has passed on this PR, I'm gonna say we can safely merge it. However, we should setup a process to determine the MSRV for this crate, so that we don't stop supporting older Rust toolchains.

Sounds good, and I agree. I've run cargo-msrv against the repo and it determined the MSRV to be 1.58.1 (released 2022-01-20). We could pin the rust-version in Cargo.toml to 1.58 and integrate cargo msrv verify in CI. It seems like we're mostly dependent on attohttpc though, which does not specify an MSRV.

Also, could you review the other open PRs?

Sure, we probably should put a rust-version key too. Then we can use cargo-msrv in CI, as per your suggestion.

I've approved #24, #23. Sorry, it must have slipped through my radar. #22 needs rebasing, but would it be helpful if I were to do that, just to speed up the PR?

Thanks.

InputUsername commented 5 months ago

Sure, we probably should put a rust-version key too. Then we can use cargo-msrv in CI, as per your suggestion.

I've made an issue (#28).

I've approved #24, #23. Sorry, it must have slipped through my radar. #22 needs rebasing, but would it be helpful if I were to do that, just to speed up the PR?

Thanks.

No worries, I've merged them now, thanks. And sure, go ahead and rebase!