Closed dependabot[bot] closed 5 months ago
@shymega
As CI has passed on this PR, I'm gonna say we can safely merge it. However, we should setup a process to determine the MSRV for this crate, so that we don't stop supporting older Rust toolchains.
Sounds good, and I agree. I've run cargo-msrv against the repo and it determined the MSRV to be 1.58.1 (released 2022-01-20). We could pin the rust-version
in Cargo.toml
to 1.58 and integrate cargo msrv verify
in CI. It seems like we're mostly dependent on attohttpc though, which does not specify an MSRV.
Also, could you review the other open PRs?
@shymega
As CI has passed on this PR, I'm gonna say we can safely merge it. However, we should setup a process to determine the MSRV for this crate, so that we don't stop supporting older Rust toolchains.
Sounds good, and I agree. I've run cargo-msrv against the repo and it determined the MSRV to be 1.58.1 (released 2022-01-20). We could pin the
rust-version
inCargo.toml
to 1.58 and integratecargo msrv verify
in CI. It seems like we're mostly dependent on attohttpc though, which does not specify an MSRV.Also, could you review the other open PRs?
Sure, we probably should put a rust-version
key too. Then we can use cargo-msrv
in CI, as per your suggestion.
I've approved #24, #23. Sorry, it must have slipped through my radar. #22 needs rebasing, but would it be helpful if I were to do that, just to speed up the PR?
Thanks.
Sure, we probably should put a
rust-version
key too. Then we can usecargo-msrv
in CI, as per your suggestion.
I've made an issue (#28).
I've approved #24, #23. Sorry, it must have slipped through my radar. #22 needs rebasing, but would it be helpful if I were to do that, just to speed up the PR?
Thanks.
No worries, I've merged them now, thanks. And sure, go ahead and rebase!
Updates the requirements on attohttpc to permit the latest version.
Release notes
Sourced from attohttpc's releases.
Commits
42cdf28
Version 0.28.0f5c65b3
Bump the all group with 1 update (#165)97642fd
Add method to get mutable reference to HeaderMap of request builder (#164)3bd674b
Update dependabot config1273f68
Update env_logger requirement from 0.10.0 to 0.11.0 (#160)f1fc784
Update to actions/checkout@v4 (#158)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show