search

InputUsername / listenbrainz-rs

ListenBrainz API bindings for Rust
https://crates.io/crates/listenbrainz
MIT License
12 stars 6 forks source link

Allow serializing api responses #35

Closed RustyNova016 closed 2 months ago

RustyNova016 commented 2 months ago

Added the Serialize macro to JSON responses to be able to serialize them back. It's useful for writing the json back to disk for tests/backups, or even make a middleware app

RustyNova016 commented 2 months ago

I'll also remind to maybe release 8.0? It's not an issue for me as I uploaded my own temporary crate for it, but for others this would be intresting

shymega commented 2 months ago

I'll create a tracking issue and milestone for this.

shymega commented 2 months ago

Just to clarify for anyone reading, this would be v0.8.0.

InputUsername commented 2 months ago

I'll also remind to maybe release 8.0? It's not an issue for me as I uploaded my own temporary crate for it, but for others this would be intresting

Yeah, I have been neglecting this, sorry. I'll take some time to review PRs tonight or tomorrow and get the release out ASAP.

InputUsername commented 2 months ago

@RustyNova016 Should #31 be merged before this PR, or are they separate?

shymega commented 2 months ago

@RustyNova016 Just on this,

It's not an issue for me as I uploaded my own temporary crate for it, but for others this would be interesting

I'm a little alarmed by this, because uploading a crate with a similar name to this crate could leave people with outdated code. Or do you use your crate as a non-Crates.io dep?

shymega commented 2 months ago

@RustyNova016 Should #31 be merged before this PR, or are they separate?

@InputUsername I think, given how large v0.8.0 will be, we should put #31 on the backburner. It seems to be a WIP as well I think?

InputUsername commented 2 months ago

@InputUsername I think, given how large v0.8.0 will be, we should put #31 on the backburner. It seems to be a WIP as well I think?

I don't think it's WIP but it's definitely outdated compared to some of the later PRs. So, I agree with pushing #31 forward, and let's merge this one.

RustyNova016 commented 2 months ago

@RustyNova016 Just on this,

It's not an issue for me as I uploaded my own temporary crate for it, but for others this would be interesting

I'm a little alarmed by this, because uploading a crate with a similar name to this crate could leave people with outdated code. Or do you use your crate as a non-Crates.io dep?

I did put an huge disclaimer on this. But can't do a much else, as uploading a crate to crates.io needs the dependency to be on crates.io.

https://crates.io/crates/listenbrainz_rs_nova

shymega commented 2 months ago

@RustyNova016 Just on this,

It's not an issue for me as I uploaded my own temporary crate for it, but for others this would be interesting

I'm a little alarmed by this, because uploading a crate with a similar name to this crate could leave people with outdated code. Or do you use your crate as a non-Crates.io dep?

I did put an huge disclaimer on this. But can't do a much else, as uploading a crate to crates.io needs the dependency to be on crates.io.

https://crates.io/crates/listenbrainz_rs_nova

Yeah... I mean, you don't need to upload a crate for this to work. You can just use your fork as a Git dependency, locked to a SHA revision, and it'll work fine.