search

Inria-Asclepios / medInria-public

Open-source part of the medInria software
https://med.inria.fr/
BSD 4-Clause "Original" or "Old" License
0 stars 9 forks source link

[pyncpp] multiple compilation fail #848

Open mathildemerle opened 7 months ago

mathildemerle commented 7 months ago

I've seen several times a same compilation bug (and Andony had it too), if you stop a MUSICardio/medInria compilation, or rebuild a part of your compilation, you can have a pyncpp fail:

[  5%] Performing build step for 'pyncpp'
[  5%] Performing post_install step for 'pyncpp_python'
/home/mathildemerle/Dev/MUSICardio4.1/medInria-public_ExtProjs/build/pyncpp/lib/python3.10/bin/python3.10_bin: ligne 7: /home/mathildemerle/Dev/MUSICardio4.1/medInria-public_ExtProjs/build/pyncpp/lib/python3.10/bin/python3.10_bin: Liste d'arguments trop longue
/home/mathildemerle/Dev/MUSICardio4.1/medInria-public_ExtProjs/build/pyncpp/lib/python3.10/bin/python3.10_bin: ligne 7: /home/mathildemerle/Dev/MUSICardio4.1/medInria-public_ExtProjs/build/pyncpp/lib/python3.10/bin/python3.10_bin: Succès
make[5]: *** [python/CMakeFiles/pyncpp_python.dir/build.make:126 : python/stamp/pyncpp_python-post_install] Erreur 126
make[4]: *** [CMakeFiles/Makefile2:134 : python/CMakeFiles/pyncpp_python.dir/all] Erreur 2
make[3]: *** [Makefile:136 : all] Erreur 2
make[2]: *** [superbuild/CMakeFiles/pyncpp-install.dir/build.make:78 : /home/mathildemerle/Dev/MUSICardio4.1/medInria-public_ExtProjs/build/Stamp/pyncpp/pyncpp-build] Erreur 2
make[1]: *** [CMakeFiles/Makefile2:235 : superbuild/CMakeFiles/pyncpp-install.dir/all] Erreur 2
make: *** [Makefile:156 : all] Erreur 2

For instance here, first i compiled MUSICardio, then changed a commit, killed my build directory (keeping external projects directories), and compiled again.

fcollot commented 6 months ago

If you are removing your superproject build directory you must also remove the external projects directories, as they are part of the superbuild. Leaving them may cause issues (which are not related the the external project).

mathildemerle commented 6 months ago

The problem is that pyncpp is the only external project to create that problem. If you stop your compilation the first time, or if there is a compilation problem somewhere, in the past you could just relaunch the compilation. Now because of that bug in pyncpp we need to either removes specifically pyncpp or kill everything in build+external projects, before relaunching the compilation. It looks like a bug we had a long time ago with patchs that gave errors when you were redoing a compilation if there was an error

fcollot commented 6 months ago

I have also had issues with external projects (not just pyncpp) when stopping the medInria superbuild before it finishes. It is very likely an issue with the superbuild itself.

fcollot commented 6 months ago

The problem is that pyncpp is the only external project to create that problem. If you stop your compilation the first time, or if there is a compilation problem somewhere, in the past you could just relaunch the compilation. Now because of that bug in pyncpp we need to either removes specifically pyncpp or kill everything in build+external projects, before relaunching the compilation. It looks like a bug we had a long time ago with patchs that gave errors when you were redoing a compilation if there was an error

Just to be clear, you are having this bug when stopping the superbuild and restarting it (without deleting anything) ? Or are you talking about the case you described above where you only delete the main build directory ?

The result you posted: 

[  5%] Performing build step for 'pyncpp'
[  5%] Performing post_install step for 'pyncpp_python'

shows the pyncpp build is trying to install the Python interpreter without having compiled it. I have rebuilt pyncpp hundreds of times without this ever happening, which is why I think it is an issue with the superbuild timestamps not being handled properly.

mathildemerle commented 6 months ago

It appears also indeed if you restart the superbuild without deleting anything. It happened a lot to Andony for instance which compiled for the first time and he had some troubles with prerequisites which stopped the compilation. It can happen also if you manually stop your compilation because you forgot to change something in your code not related to pyncpp

fcollot commented 6 months ago

pyncpp is the only external project that uses its own external projects (Python for example), so this could also explain why it is the only project to have these issues. It may be that you are stopping the superbuild during the compilation of Python, and that the build doesn't detect that the compilation step was not finished (which seems to be what is happening from the output you posted). I can try reproducing this on pynccp directly to see if the issue appears independently from the superbuild.