InsaLan / backend-insalan.fr

Backend of the insalan website
MIT License
2 stars 0 forks source link

Add missing fields for tournaments #93

Closed istar410 closed 11 months ago

istar410 commented 12 months ago

Add missing fields like team password (#88), player/manager pseudo and max number of teams in a tournament (#49). Also fixing unique registration per event validation.

istar410 commented 11 months ago

I would really appreciate some help for fixing tests :)

ShiroUsagi-san commented 11 months ago

I'm not sure that the validator checking if a manager is not also a player is correct. The last failing test is about if we should raise IntegrityError or ValidityError.

Lymkwi commented 11 months ago

Hi, so, I finally managed to focus enough to run the tests and investigate what's wrong, here's what I found out

I'm not sure that the validator checking if a manager is not also a player is correct. The last failing test is about if we should raise IntegrityError or ValidityError.

Yes and no. Yes: the validation test is completely broken at the moment. No: it's not a matter of validation error or not; test code is raising errors on the first instance of registration, where no conflict should exist yet. Something is wrong with validation in a way that I haven't pinned down yet but which is definitely exhibited by our tests.

As for the second kind of tests, they happen to crash because test code was pushed in the pull request, and user tests previously written by @Lugrim check for the presence of the email validation URL in the body of emails returned by calling the registration URL.

So we have two things to do before we can merge this PR:

Lymkwi commented 11 months ago

(oh of course we will have to rebase this whole mess with dev before merging)