Insane96 / CustomFluidMixin

Custom Fluid Mixin is a pack developer mod that let you change how fluids interact, creating blocks and such
https://www.curseforge.com/minecraft/mc-mods/custom-fluid-mixin
6 stars 1 forks source link

It doesn't work. #17

Closed 7yudinglaopin8 closed 3 weeks ago

7yudinglaopin8 commented 1 month ago

I don't understand what's wrong with the structure of my datapack. JEI didn't even read the recipe...

Insane96 commented 1 month ago

Use discord for help. This is an issue tracker

7yudinglaopin8 commented 1 month ago

Use discord for help. This is an issue trackerUse discord for help. This is an issue tracker I cannot use Discord or YouTube on the mainland of China…………

Insane96 commented 1 month ago

Then first of all check logs

7yudinglaopin8 commented 3 weeks ago

betternetherfix-0.0.1-datapack-1.20.1.zip

7yudinglaopin8 commented 3 weeks ago

I have sent you the datapack I wrote. Can you help me find some problems?

Insane96 commented 3 weeks ago

Your json is not valid. Use an IDE that has JSON validator

7yudinglaopin8 commented 3 weeks ago

Your json is not valid. Use an IDE that has JSON validator

What should I correct?

Insane96 commented 3 weeks ago

https://jsonlint.com

7yudinglaopin8 commented 3 weeks ago

https://jsonlint.com

Thanks

7yudinglaopin8 commented 3 weeks ago

The function part has no effect. Why?

7yudinglaopin8 commented 3 weeks ago

betternetherfix-0.0.1-datapack-1.20.1.zip

7yudinglaopin8 commented 3 weeks ago

https://jsonlint.com

My JSON is valid. My function is also valid. But this code never runs the function:

{ "type": "flowing_block", "flowing": "minecraft:lava", "blocks_nearby": [ "minecraft:soul_sand", "#minecraft:water" ], "result": { "type": "function", "function": "betternethermixin:doblueobsidian" } }

Insane96 commented 3 weeks ago

Read the documentation, it's stated there why "flowing" is not correct

7yudinglaopin8 commented 3 weeks ago

Read the documentation, it's stated there why "flowing" is not correct

Uh, sorry, I still can't see the problem.Can you guide me? Thanks.

7yudinglaopin8 commented 2 weeks ago

Hey, are you still here?

Insane96 commented 2 weeks ago

flowing: the fluid tag (e.g. don't use "minecraft:water", use "#minecraft:water") that's flowing

7yudinglaopin8 commented 2 weeks ago

flowing: the fluid tag (e.g. don't use "minecraft:water", use "#minecraft:water") that's flowing

No, this is the code I specially designed for the liquid source box, I do not want to have flowing magma pouring event, the problem is the function call, the previous code can be used in other JSON normal.

7yudinglaopin8 commented 2 weeks ago

For example, this code will work. { "type": "flowing_block", "flowing": "minecraft:lava", "blocks_nearby": [ "minecraft:soul_sand", "#minecraft:water" ], "result": { "type": "blocks", "blocks": "betternether:blue_obsidian" } }

Insane96 commented 2 weeks ago

Is the function properly loaded?

7yudinglaopin8 commented 2 weeks ago

I can load my functions correctly in the game using the /function command.

7yudinglaopin8 commented 2 weeks ago

Is the function properly loaded?

betternetherfix-0.0.1-datapack-1.20.1.zip

Insane96 commented 2 weeks ago

There is no advancement, how can that work?

7yudinglaopin8 commented 2 weeks ago

This datapack is prepended with run betternether mod on forge with Sinytra Connector to fix the bug that advancement exists in the betternether mod.

7yudinglaopin8 commented 2 weeks ago

There is no advancement, how can that work?

That is, the datapack is preceded by betternether mod. The advancement itself is not inside my datapack.

Insane96 commented 2 weeks ago

Does it work if you put "say hi" in the function?

Insane96 commented 2 weeks ago

Also check the logs for errors

7yudinglaopin8 commented 2 weeks ago

Does it work if you put "say hi" in the function?

Let me test it out and I will also try to change modded advancement to vanilla advancement for testing.

7yudinglaopin8 commented 2 weeks ago

But I'm a little busy right now, so it might take a while.

7yudinglaopin8 commented 2 weeks ago

latest.log @Insane96 The issue appears to have arisen during the invocation of the function in my experiments. I tried to add /tell to it, but it still didn't work. Finally, I deleted all the modded code in the function, and it still has no effect.

Insane96 commented 2 weeks ago

Send the latest edits

7yudinglaopin8 commented 2 weeks ago

debug.log latest.log 2024-10-20-2.log.gz debug-1.log.gz

Insane96 commented 2 weeks ago

Data pack?

7yudinglaopin8 commented 1 week ago

Data pack?

betternetherfix-0.0.1-datapack-1.20.1.zip Need bettternether mod(for forge)(Sinytra Connector) I still recommend testing it out for yourself in the game, and it seems to be a problem with your mod, there's no way to execute functions.

Insane96 commented 1 week ago

@s will never work as the player is not the executer

7yudinglaopin8 commented 1 week ago

@s will never work as the player is not the executer

Thank you, but how can I correct it? What is @s corrected to be?

Insane96 commented 1 week ago

https://minecraft.wiki/w/Target_selectors

Il Dom 27 Ott 2024, 13:49 C8H11NO2 @.***> ha scritto:

@s will never work as the player is not the executer

Thank you, but how can I correct it? What is @s https://github.com/s corrected to be?

— Reply to this email directly, view it on GitHub https://github.com/Insane96/CustomFluidMixin/issues/17#issuecomment-2440002815, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW2FUACI6KTZRV2AYOO7STZ5TOL7AVCNFSM6AAAAABPNN22Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGAYDEOBRGU . You are receiving this because you were mentioned.Message ID: @.***>

7yudinglaopin8 commented 1 week ago

https://minecraft.wiki/w/Target_selectors Il Dom 27 Ott 2024, 13:49 C8H11NO2 @.> ha scritto: @s will never work as the player is not the executer Thank you, but how can I correct it? What is @s https://github.com/s corrected to be? — Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW2FUACI6KTZRV2AYOO7STZ5TOL7AVCNFSM6AAAAABPNN22Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGAYDEOBRGU . You are receiving this because you were mentioned.Message ID: @.>

After reading it, I feel even more confused...