search

Insane96 / IguanaTweaksReborn

Repository for ported and maintained version of IguanaTweaks
https://www.curseforge.com/minecraft/mc-mods/iguanatweaks-reborn
13 stars 12 forks source link

Make hitting mobs with Fists have no knockback (Suggestion) #60

Closed SirAron111 closed 5 years ago

SirAron111 commented 6 years ago

I really like the tweaks that you can make with this mod.

I think an option to remove the knockback from the payer who doesn’t use a tool (or with the attack speed bar not fully filled (slower fill up time for fists)) would be a nice addition. For example its way to easy to fight mobs by just spamming the hit key and pushing them into a corner they can’t even respond to that.

Would it be possible to add something like this?

Insane96 commented 6 years ago

Love the idea. I'll check what I can do 👍

SirAron111 commented 6 years ago

Better with Mods has a feature like this but the mod just kept causing problems so I had to remove it than I saw iguana updated and thought he this feature would fit with the mod so XD.

But the only concerns I have is that this could impact the knockback when the player uses non vanilla tools like tinkers weapons or (add-ons for tinkers like yoyos mod or the like).

Also that it may be too easy to work around by just holding an item like a dirt block or a stick in your hand as these times aren’t weapons and shouldn’t knockback mobs to.

Would love to have this feature for my Modpack Dimension Zero? And thx for the fast replay.

Insane96 commented 5 years ago

It's pretty hard disabling knockback since it's hardcoded. The best thing I can do is disable the damage completely when it's too low. Plus seems like the method that should give the current attacks speed seems to not work properly.

PS I'm going to try your modpack, I'm a little bit curious now 😛

SirAron111 commented 5 years ago

If it would be possible to at least disable attacking completely when the attack speed meter isn’t fully charged (to prevent spam clicking) that would already be good enough for me.

Since there are many ways to get attack speed increases like Redstone on tinkers weapons or increasing attack speed with the abilities mod I have in the pack. This would make it harder on early game to do think like abuse rapiers or just spam hit with your fist to fight mobs.

I remember that better with mods did something to disable knockback with fists but that doesn’t really matter that mod did alot of lagy things so i removed it.

PS: My pack isn’t a professional one it’s something I do in my free time XD I constantly have some ideas I would like to add but since I am not a Modder I can’t do that.

For example I really wish that I could somehow spawn rifts that sometimes appear and spawn mobs to fit the story of the pack but atm all I can do to make this somehow seem like that’s the case I have naturally generating nether portals, randomly spawning thaumcraft rifts and the dimensional rifts from dim doors mod they would be the best for this but they are only ambient atm growing in size if you don’t close them and make it seem like they are dangerous but actually aren’t.

But do have fun and feel free to join the discord if you need help people there are really nice and helpful. And thx for listening to this idea anyway.

Insane96 commented 5 years ago

If it would be possible to at least disable attacking completely when the attack speed meter isn’t fully charged (to prevent spam clicking) that would already be good enough for me.

That's another problem since seems like the method that should return the attack meter / cooldown / whatever, doesn't work properly. BUT, I've found a solution. That's now how it works. (Copy pasted from the config comment 😝) If the player has an item that deals no damage (so with fist, or even a stick) the attacked mob will take almost no damage (1/20 of a hearth) and no knockback. That applies even if the player attack speed cooldown is below 50% EDIT: Changed mechanic to: If the player attacks an entity without a tool / weapon, the attacked mob will take almost no damage (1/20 of a heart) and no knockback. The no knockback applies even if the player attack speed cooldown is below 75% with a tool / weapon, but in this case the damage is applied normally If you have any other suggestion about this, go on

Insane96 commented 5 years ago

Closed via https://github.com/Insane-96/IguanaTweaksReborn/commit/b052c7b4e2f2ed2aedef0aee322f0547982f8c47 and https://github.com/Insane-96/IguanaTweaksReborn/commit/99d50954fb80c5168b32e272537cce6b2af0ce28