Ability to switch between a textarea and the full editor

Inscryb / inscryb-markdown-editor

A simple, beautiful, and embeddable JavaScript Markdown editor. Based off SimpleMDE by Sparksuite.

MIT License

90 stars 16 forks source link

Ability to switch between a textarea and the full editor #34

Closed Grestorn closed 5 years ago

Grestorn commented 5 years ago

I've added the ability to give the user an option to switch between the full editor and a simple TextArea. The reason is, that CodeMirror doesn't work all to well on iOS devices. Some users prefer the simple text area which still allows them to use the standard iOS text correction functionality.

See the changes in the README for the details.

I didn't do a full test (I don't have a test environment, do you?) but it seems to work fine with my setup. The "autoSave" feature will probably not work to well if you start the editor in TextArea mode.

CWharton commented 5 years ago

Did you rebase your branch before creating your PR?

Grestorn commented 5 years ago

Nope, sorry. Since I just forked two days ago... If you want, you can deny it and I'll do it from scratch. Or you just throw away the dist files from my pull request and merge the rest. Up to you. Sorry for the hassle. (I'm still getting familiar with the whole pull request business :) )

Grestorn commented 5 years ago

Is this ok now? I'm really sorry, still got a lot to learn how to properly share contributions on github.

CWharton commented 5 years ago

We are all learning here as we go. Thank you for the contribution. It is appreciated.