search

Inscryb / inscryb-markdown-editor

A simple, beautiful, and embeddable JavaScript Markdown editor. Based off SimpleMDE by Sparksuite.
MIT License
90 stars 16 forks source link

Add `class` to toolbar buttons #43

Open jonyhayama opened 5 years ago

jonyhayama commented 5 years ago

I'm submitting a...

Request

Add class with button names to toolbar buttons.

Current version is:

<div class="editor-toolbar">
  <button title="Bold (Ctrl-B)" tabindex="-1"><i class="fa fa-bold"></i></button>
  ...
</div>

I'd like to propose we simply add a class, like this:

<div class="editor-toolbar">
  <button title="Bold (Ctrl-B)" class="editor-button-bold" tabindex="-1"><i class="fa fa-bold"></i></button>
  ...
</div>

This would allow CSS styles to be applied on a single button, eg. A save button shown in a different color when it detects changes that nees to be saved.

I'm more than happy to submit a Pull Request, I'm opening this issue just to check if it is OK to do so :)

CWharton commented 5 years ago

I would gladly welcome a PR