Merge the two Identity Providers & code refactoring

InseeFr / Keycloak-FranceConnect

Extension Keycloak facilitant l'utilisation de FranceConnect

MIT License

87 stars 31 forks source link

Merge the two Identity Providers & code refactoring #33

Closed mboisnard closed 4 years ago

mboisnard commented 4 years ago

Resolves #11

Add FranceConnect environment selector in partial
Remove FranceConnect Test Identity Provider
Add Enums to represent Environment and Eidas Level
Refactor existing code and create packages

Please update the authorized redirect_uri for INSEE Test account after merging this PR.

micedre commented 4 years ago

Thanks for the PR and sorry for the delay. At first look it seems fine to me. Could you update the README(s) with a doc on migration (eg, if we already have configured the Test provider, what happens on update?) ?

mboisnard commented 4 years ago

Readme(s) update done for migration process and I made some updates with the readme format:

Compatibility section (keycloak compatible version can be changed if you want, actual : from 4.5.0 with 4.8.0 exception, in this PR: from 4.8.1.Final)
Installation process
Requirements
Mappers configuration

micedre commented 4 years ago

Thank you for all that work, could I ask you to rebase on the last master?

mboisnard commented 4 years ago

Thank you for all that work, could I ask you to rebase on the last master?

Done :)