InseeFr / Keycloak-FranceConnect

Extension Keycloak facilitant l'utilisation de FranceConnect
MIT License
87 stars 31 forks source link

Use GitHub actions #44

Closed Donatien26 closed 3 years ago

Donatien26 commented 3 years ago

what do you think of this ? i recommend to squash commit before merging :)

micedre commented 3 years ago

lgtm, @mboisnard, what do you think?

mboisnard commented 3 years ago

@micedre seems good to me. Just a little question: is it good to have a different filename than the release name?

micedre commented 3 years ago

@micedre seems good to me. Just a little question: is it good to have a different filename than the release name?

* filename uses $(echo $GITHUB_REF | cut -d / -f 3)  ==> aka tagName: tagPart1/tagPart2/tagPart3 (is this case possible/useful??), filename: keycloak-franceconnect-tagPart1.jar

* release tagName & releaseName : ${{ github.ref }} ==> aka tagPart1/tagPart2/tagPart3 in my example
  Do you really need to "cut -d / -f 3" with your tag convention?

GITHUB_REF is something like "refs/tags/v1.2.3", we just want the last part I think (but for both, maybe we can set it globally, to use it everywhere, @Donatien26 , can ou look into it ?)

micedre commented 3 years ago

I'm merging this, we can always modify it later.