search

InseeFr / Lunatic

Library of questionnaire components
https://inseefr.github.io/Lunatic/
MIT License
20 stars 22 forks source link

Label Position #404

Closed isMattCoding closed 7 months ago

isMattCoding commented 1 year ago

The labels have been refactorised and separated from the components. In a well-formed design system, the labels should be rendered directly with the component. This is the case in the DSFR. It would be preferable to restructure the components so that the labels are included in and rendered by each component.

AnneHuSKa commented 1 year ago

ok, go ahead, :-)

AnneHuSKa commented 1 year ago

Is it the same issue as this one : https://github.com/InseeFr/Lunatic/issues/274 ?

isMattCoding commented 1 year ago

Is it the same issue as this one : #274 ?

It's related, in the sense that the components in the first point of issue #274 need to be reconsidered.
In the second point, it is not clear whether the intention is to leave the labels as <span> or to change them to <label>. To be clear, our intention is to replace the <span> on all composants that require a <label>, and to ensure that the <label> is rendered at the composant level, and not rendered separately.