search

InseeFr / Lunatic

Library of questionnaire components
https://inseefr.github.io/Lunatic/
MIT License
20 stars 22 forks source link

Update @inseefr/vtl-2.0-antlr-tools Version #823

Closed ddecrulle closed 6 months ago

ddecrulle commented 11 months ago

Our current project relies on version [^0.1.0-bundle] of @inseefr/vtl-2.0-antlr-tools. However, a newer version, [0.3.0], has been released.

Motivation for the Update:

The latest release of vtl-2.0-antlr-tools utilizes version 4.8.0 of antlr4. This version ensures compatibility with webpack 5.

This update is anticipated to resolve issues in the orchestrator that arise when using Webpack 5 (Error: Can't resolve 'fs' in ...).

Although attempting a straightforward version upgrade led to numerous test failures. This is an important part of lunatic because we use vtl-2.0-antlr-tools to built the vtl bindings dependency tree.

ddecrulle commented 11 months ago

The build of version 0.3.0 is not ESM-compatible. The latest version of Trevas-JS that we are using relies on VTL 0.1.0. For now, I suggest migrating to this version and updating the version number once it becomes ESM-compatible, while keeping it consistent with the one used by Trevas.

ddecrulle commented 11 months ago

I've had a conversation with @NicoLaval (trevas maintainer), and there's an upcoming version of the package here. However, it's currently in the planning stage and not yet accessible in Trevas.