search

InseeFrLab / Trevas-Jupyter

Jupyter notebook providing VTL support through Trevas engine
MIT License
2 stars 2 forks source link

Fix: #66 #107

Closed jornfranke closed 5 months ago

jornfranke commented 5 months ago

Our original fix for #66 did not work very well. That should solve it.

jornfranke commented 5 months ago
  • Are you sure about conf.get("spark.jars","")? I think it's conf.get("spark.jars")

Yes, the second parameter is the default value to be used if the variable does not exist.

  • Check code indent please

I will, btw. what do you think - does it make sense to integrate spotless into the Maven? https://github.com/diffplug/spotless

Then I can do this automatically.

NicoLaval commented 5 months ago
  • Are you sure about conf.get("spark.jars","")? I think it's conf.get("spark.jars")

Yes, the second parameter is the default value to be used if the variable does not exist.

Ah, nice.

  • Check code indent please

I will, btw. what do you think - does it make sense to integrate spotless into the Maven? https://github.com/diffplug/spotless

Then I can do this automatically.

Yes, good point to associate a common formatting configuration to the project