Closed JackLemaitre closed 11 months ago
I suggest the next changes:
This give this:
proxyConfig:
landingPage: /
heartbeatRate: 10000
heartbeatTimeout: 60000
containerWaitTime: 20000
port: 8080
authentication:
type: none
# type: openid
# openid:
# authURL: ""
# tokenURL: ""
# jwksURL: ""
# logoutURL: ""
# usernameAttribute: ""
# rolesClaim: ""
# existingClientCredentialsSecretName: ""
existingAppsSecretName:
apps:
- id: ""
display-name: ""
description: ""
container-image: ""
container-cmd: []
access-groups: []
I suggest that version: 1.0.4 start now from 2.0.0 as there is some breaking change.
it could be nice to have a README.md just aside values.yaml the content should be just the main use case of the secrets something like :
This helm chart allow to deploy a customised shinyproxy app.
With or without oidc, if using oidc pay attention to deploy yourself a secret that contains:
apiVersion: v1
kind: Secret
metadata:
name: oidc-secret
stringData:
client-id: someValue
client-secret: someValue
You can customized the application.yml file in the apps helm values.
If you want to add some env variable you cas use container-env if you want to protect secret you can deploy yourself a secret like this, let say you have 2 applications:
apiVersion: v1
kind: Secret
metadata:
name: oidc-secret
stringData:
app1:|
VAR_EXAMPLE_1=value1
VAR_EXAMPLE_2=value2
app2:|
VAR_EXAMPLE_1=otherValue1
VAR_EXAMPLE_3=value3
This file will be injected in /opt/shinyproxy/conf/app1 and app2, then your application.yml configuration can specify `container-env-file: /opt/shinyproxy/app1
container-env and container-env-file can be mixed.
in this PR: