InseeFrLab / images-datascience

Collection of Docker images to build the data science catalog of the Onyxia project
MIT License
24 stars 22 forks source link

onyxia-init.sh / repositories : use appending redirection (fix for DARK_MODE transmission) #179

Closed phlg closed 8 months ago

phlg commented 8 months ago

Some users of our in-house deployed Onyxia reported that the dark mode was not correctly propagated to RStudio based images. It appears this is due to the way these images are configured with the onyxia-init.sh and onyxia-set-repositories.sh scripts.

Prior to https://github.com/InseeFrLab/images-datascience/pull/148, only the onyxia-set-repositories.sh file had some logic related to managing the ${R_HOME}/etc/Rprofile.site file, and as such, used standard redirection (>) to initialize the file.

Since #148, onyxia-init.sh now has precedence in modifying this file... but these modifications are then lost (overwritten) by the onyxia-set-repositories.sh instructions when a custom repository is configured.

This one-character PR just changes the first instruction in onyxia-set-repositories.sh to use append redirection (>>) instead of the standard one, in hope of fixing this problem.