InseeFrLab / onyxia

🔬 Data science environment for k8s
https://onyxia.sh
MIT License
458 stars 80 forks source link

Hide/filter unstable chart versions for non-developers #709

Closed Andilun closed 4 months ago

Andilun commented 9 months ago

Issue description: Currently, in the Onyxia web version dropdown menu, all versions of charts are displayed, including unstable ones (like rc or beta versions).

Our issue stems from not wanting to expose potentially unstable rc or beta versions to our users, while using the same chart repo across multiple environments.

Example:

Dropdown menu issue

Possible solution: A solution could be a filter that would exclude chart versions containing a hyphen '-' while not in developer mode. This solution would eliminate the need for duplicating or forking chart repositories for different environments and remove the risk of exposing users to unstable versions unless they specifically opt-in.

garronej commented 9 months ago

Thanks for reporting @Andilun,

This is a bug. I'll fix it now.

Andilun commented 9 months ago

Thanks @garronej 🥇

Could a condition to allow developers to view all versions be added? Something like .filter(({ version }) => isDevModeEnabled ? true : !version.includes("-")).

garronej commented 9 months ago

@Andilun, sure that can be done

fcomte commented 4 months ago

what is the status of this issue @garronej ?

garronej commented 4 months ago

@fcomte @Andilun Sorry for not following up on this. The behavior was changed since it was last discuted.
Currently the beta, alpha release candidates ect. are never selected by default but are always sown in the dropdown for selecting version in the launcher page.
According to me, this allright, it's a bit like NPM does it. You'll never mistakingly pull an alpha but you can spin it up if you want to.
I can still hide thoses versions in non dev mode if you're not happy with the curent state of things.

I'll close this issue but do not hesitate to reopen.