Add support for oidc extra params from api

InseeFrLab / onyxia

🔬 Data science environment for k8s

https://onyxia.sh

MIT License

458 stars 80 forks source link

Add support for oidc extra params from api #739

Closed johnksv closed 8 months ago

johnksv commented 8 months ago

In some use cases the user want to specify extra query parameters. E.g. prompt type. This can now be done by specifying the parameters in the API. The frontend will use those parameters and send it along in the oidc flow.

Draft PR for visibility until code is ready for review.

garronej commented 8 months ago

Hey Jhon!

Thank you for the PR!

This is probably a parameter that we want to add at the region level alongside with the other oidc parameters.
I'll synchronise with @fcomte and @olevitt and we'll do it soon!

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

johnksv commented 8 months ago

Rebased to make changes align with upcoming changes in API (https://github.com/InseeFrLab/onyxia-api/pull/378).

garronej commented 8 months ago

Looking good! there's just a few litle details to adress. I'll fix them and merge tomorrow!
Thanks a lot for your contribution