search

InseeFrLab / onyxia

🔬 Data science environment for k8s
https://onyxia.sh
MIT License
458 stars 80 forks source link

Activating quotas after user creation raise an error when accessing "my services" #769

Closed nitreb closed 7 months ago

nitreb commented 7 months ago

We have activated quotas for our project, and when a user tries to access "my services", a pop up with TypeError: can't convert undefined to object appears. It seems that the error is raised because there is no kubernetes ResourceQuota associated with the user namespace. Even though we will manually create ResourceQuota for each user, I feel like this must be dealt with in the frontend.

Thanks!

fcomte commented 7 months ago

can you show the api response for the quota request on onyxia-api ?

nitreb commented 7 months ago

I got an empty response but with status 200, nothing much to show...

fcomte commented 7 months ago

@olevitt @garronej

so I guess onyxia-web must handle this 200 empty response?

garronej commented 7 months ago

I'll handle this on the application side but I think the API should respond with { "spec": [], "usage": [] } instead of an empty 200.

fcomte commented 7 months ago

agree

olevitt commented 7 months ago

Done in https://github.com/InseeFrLab/onyxia-api/pull/400
Will be in API v2.3.0, soon to be released

garronej commented 7 months ago

Cool thanks I've fixed it on my side in the meantime but I'll revert my changes