search

InseeFrLab / onyxia

🔬 Data science environment for k8s
https://onyxia.sh
MIT License
458 stars 80 forks source link

The .env file mentions CUSTOM_RESOURCES_URL and CUSTOM_RESOURCES #776

Closed nitreb closed 6 months ago

nitreb commented 6 months ago

I think CUSTOM_RESOURCES_URL is deprecated? We manage to make it work by using CUSTOM_RESOURCES. Both are mentioned in the .env file and it might be confusing for the users. What do you think?

odysseu commented 6 months ago

Indeed, I can also see the 2 variables appear in the code:

garronej commented 6 months ago

Hello @nitreb,
Thanks for the feedback,
The CUSTOM_RESOURCES_URL is not deprecated but it's an internal parameter that isn't supposed to be customized.

image

Everywhere else, only CUSTOM_RESOURCES is mentioned. This is what needs to be used.

I'll remove or rename CUSTOM_RESOURCES_URL to clearup confustion.

garronej commented 6 months ago

I admit it was missleading, I found another way so that there's no need for the CUSTOM_RESOURCES_URL internal variable.

Thanks for reporting