search

InseeFrLab / onyxia

🔬 Data science environment for k8s
https://onyxia.sh
MIT License
432 stars 78 forks source link

Allow S3 public bucket configuration in project settings #807

Closed slim0 closed 1 month ago

slim0 commented 2 months ago

I think we already discussed that with you but we would like to configure a public bucket on the project settings (without giving access key id and secret).

I found this workaround on an issue in the aws-sdk library to send an anonymous request. I tried it and it works on my side on a public bucket we have.

Could you please take a look at this PR and let me know.

Thx

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

garronej commented 2 months ago

Thank you for your contribution. Sorry, it slipped through my radar. I'll review this tomorrow.

garronej commented 1 month ago

actually today lol sory again

garronej commented 1 month ago

Still working on it. It has quite a few repercutions...

garronej commented 1 month ago

Hey @slim0,

It's finaly completed

https://github.com/InseeFrLab/onyxia/assets/6702424/6fde4e22-7a63-42b2-a590-21d9b0e47ce2

There is a new entry in XOnyxia:

image