Onyxia web env variable BACKGROUND_ASSET do not hide background on terms of services page

InseeFrLab / onyxia

🔬 Data science environment for k8s

https://onyxia.sh

MIT License

432 stars 78 forks source link

Onyxia web env variable BACKGROUND_ASSET do not hide background on terms of services page #810

Closed slim0 closed 1 month ago

slim0 commented 2 months ago

Hi,

We found out that setting the env variable "BACKGROUND_ASSET" to false in onyxia web do not hide the background image on the "terms and conditions" page (in onyxia keycloak theme). It works well on the login page by the way.

Regards

garronej commented 2 months ago

Hum,

I don't quite get what's going on.

I wasn't able to reproduce unfortunately.
Can you show me what you're getting in the localStorage?

slim0 commented 1 month ago

My bad, this is on the next page. The one that is asking to verify the email.

Capture d’écran 2024-05-24 à 09 03 15

garronej commented 1 month ago

Ok now that makes sense!

garronej commented 1 month ago

I foud the error. Fixing, thanks for reporting

garronej commented 1 month ago

Fixed in latest version!