search

InsertKoinIO / koin-annotations

Koin Annotations - About Koin - a pragmatic lightweight dependency injection framework for Kotlin & Kotlin Multiplatform insert-koin.io
https://insert-koin.io
Apache License 2.0
123 stars 30 forks source link

fix: check safety issue for providing SavedStateHandle & Context #101

Closed ghasemdev closed 5 months ago

ghasemdev commented 7 months ago

@arnaudgiuliani

arnaudgiuliani commented 7 months ago

Good addition. Can you add a sample test in the sandbox app? Otherwise I will manage to add it later ... but would be great to make it complete.

ghasemdev commented 6 months ago

Good addition. Can you add a sample test in the sandbox app? Otherwise I will manage to add it later ... but would be great to make it complete.

I tried to build the Sandbox project but was unsuccessful. I feel that the Gradle dependencies were outdated. I am using the latest version of Android Studio, which requires Gradle and plugin version 8.2.

ghasemdev commented 6 months ago

Also, I made the changes on my local and got the output, then tested it on my sample project and it worked.

https://github.com/ghasemdev/sample-koin-project

ghasemdev commented 6 months ago

Before

image

After

image

arnaudgiuliani commented 5 months ago

Thanks for your contribution 👍